Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RabbitMQHealthCheck for SSL endpoints #850

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Fix RabbitMQHealthCheck for SSL endpoints #850

merged 1 commit into from
Nov 4, 2021

Conversation

awakeman
Copy link

@awakeman awakeman commented Nov 4, 2021

What this PR does / why we need it:
Allows RabbitMQ.Client.ConnectionFactory to infer ssl options if none supplied.

Which issue(s) this PR fixes:

Please reference the issue this PR will close: #849

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@unaizorrilla unaizorrilla merged commit 148ec32 into Xabaril:master Nov 4, 2021
carlosrecuero added a commit that referenced this pull request Nov 9, 2021
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RabbitMQ health checks with amqps URI and null SslOptions fail to connect
3 participants