Allow configurable timeout for URI health-checks #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wdamron Let me a couple of days to check this, thanks for contribute on this project! |
unaizorrilla
reviewed
Feb 6, 2019
|
Can you create a functional tests with timeout? Probably using httbin and /delay/:n is valid to tests a timeout feature on uri health check! |
unaizorrilla
reviewed
Feb 6, 2019
| @@ -44,7 +44,19 @@ public async Task<HealthCheckResult> CheckHealthAsync(HealthCheckContext context | |||
| requestMessage.Headers.Add(header.Name, header.Value); | |||
| } | |||
|
|
|||
| var response = await httpClient.SendAsync(requestMessage); | |||
| HttpResponseMessage response; | |||
| if (_options.Timeout != TimeSpan.Zero) | |||
There was a problem hiding this comment.
is _options.Timeout or item.Timeout? You need to get _options.Timeout as default parameter if is not override with specified UriOptions. Is the same pattern we have with defaultstatuscode httpmethod etc
|
In order to close this feature and publish a new package I address the feedback and merge your changes. Thanks for contribute |
This was referenced Feb 6, 2019
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeoutoption toUriHealthCheckOptionsCancellationTokenduring HTTP request withinUriHealthCheckRelated to #81 and #60