Add Support For Azure Storage Options (Client Version) #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @GGJason Merged, on features/net50 I try to change the parameter order for BlobClientOptions. In this versions (3.3.1) this was a breaking change and I preserve your order! A new release build is on appveyor, when finished a new package 3.3.1 will be published! |
|
Thank you. It is very awesome to get such a fast response. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Azure Blob Health Checks Need Support For Custom Client Version
Which issue(s) this PR fixes:
No existing PR.
The original is that I use AzureStorage Health Check and I got an unhealty result with "Unhealty with 'null'" message.
I clone the source code and find the blob client return Header error that I solve in my application with set the client version to earlier version.
So I need to set the version of blob client to use the health check extension.
I fix it with adding an optional parameters in AddAzureBlobStorage Function and the related configurations.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Yes.
Please make sure you've completed the relevant tasks for this PR, out of the following list: