#552 RabbitMQ Use single connection when making use of IConnectionFactory

[mvonck]

What this PR does / why we need it:

Current problem
Using this library via IConnectionFactory leads to new connections everytime the healthcheck url is called.

Why register via IConnectionFactory?
Because registering via IConnection leads to startup exception when rabbitMQ is not ready yet. Registering via IConnectionFactory solves this problem.

Timeline when registering via IConnection
-------- Start website> ----CRASH in DI container->----------------
---------------------------------------------------------Start RabbitMQ

Timeline when registering via IConnectionFactory
-------- Start website ---->HealthCheck 503_---->DoOtherStuff-------->HealthCheck 200----
-------------------------------------------------------Start RabbitMQ------------------------------

Which issue(s) this PR fixes:
#552 #578 #563 #480

Special notes for your reviewer:
I did't find a mocking framework so i have addes MOQ. Maybey i overlooked it?

Does this PR introduce a user-facing change?:
i don't think so

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Unit tests passing
• End-to-end tests passing
• Extended the documentation
• Provided sample for the feature

[unaizorrilla]

I'm on review this!

[unaizorrilla]

Hi @mvonck

I'm sorry on delay reviewing this, merged! thanks for contribute a new release is on appveyor, when finished a new package with 3.1.3 will be available on nuget!

[mvonck]

@unaizorrilla thanks for merging my pull request, but with this commit mulitple connections will be created again. The reason is because now you register the HealthCheck as transient (this is the default behavior when registering a healthceck via HealthCheckBuilder).

If you (temporary) revert the functional test i have written that detects duplicate connections, you will see that it fails.

Maybey we can rewrite that test without using MoQ? I don't have time this week, but maybey next week i can help.

[unaizorrilla]

True, my fault!!!

I try to revert this and release a new version now!

[unaizorrilla]

New release 3.1.4 is on appveyor, I'm so sorry !!

I try to add this test without using moq, let me some time to do that!