HealthChecks.IbmMQ #431
Merged
HealthChecks.IbmMQ #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sungam3r
reviewed
Mar 3, 2020
src/HealthChecks.IbmMQ/DependencyInjection/IbmMQHealthCheckBuilderExtensions.cs
Show resolved
Hide resolved
sungam3r
reviewed
Mar 3, 2020
sungam3r
reviewed
Mar 3, 2020
test/FunctionalTests/HealthChecks.IbmMQ/IbmMQHealthChecksTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Mar 3, 2020
test/FunctionalTests/HealthChecks.IbmMQ/IbmMQHealthChecksTests.cs
Outdated
Show resolved
Hide resolved
…lderExtensions.cs Co-Authored-By: Ivan Maximov <sungam3r@yandex.ru>
Co-Authored-By: Ivan Maximov <sungam3r@yandex.ru>
Co-Authored-By: Ivan Maximov <sungam3r@yandex.ru>
Co-Authored-By: Ivan Maximov <sungam3r@yandex.ru>
|
@fglaeser, Im going to review and merge this PR, could you address the conflicts that appeared after merging previous PR's? Thanks |
|
@fglaeser Im testing the healthcheck with docker-compose and is working fine. I'm merging it and adding some checks and minor changes. Thank you very much for your contribution |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds healthchecks for IbmMQ.
I have created HealthChecks.IbmMQ.csproj, functional test and also some documentation.
Best Regards.