Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Bus + Event Hub: Not a new connection for each check #39

Merged

Conversation

deadwards90
Copy link
Contributor

Tried to keep as close to the Redis implementation as I could for the Service Bus one as ServiceBusConnection is exposed which helps.

However, Event Hub does not expose this so I made the client initialise in the constructor instead.

I've also updated the libraries. The Service Bus update is necessary to expose the connection so needs to be at minimum 3.X.X.

If I need to move them down to a just the latest major I can do that.

@CarlosLanderas
Copy link
Contributor

@dantheman999301 the ServiceBus DI Unit tests failed. Could you check it? Maybe the should be adapted. Thanks

@unaizorrilla
Copy link
Collaborator

Thanks for contributing this @dantheman999301 , I try to review this a soon as posible!

@unaizorrilla unaizorrilla merged commit 7dd37f9 into Xabaril:master Dec 27, 2018
@unaizorrilla
Copy link
Collaborator

Hi @dantheman999301

Merged but I perform some changes, please note for next pr:

  • If you update some package you need to update the version on dependencies.props
  • If you update nuget package the version are on dependencies props and csproj use $() variables to set this versions.
  • All if conditions need curly brackets, it is our convention

Also, I perform some changes in your code. Queue and Topic create in each healt a QueueClient and TopicClient, you reuse only the ServiceBus connection. I change to reuse the QueueClient and TopicClient and reuse the same TCP connection. The healthcheck time is improved a lot.

At this moment the build is on app veyor, if the build work ok I tag the repo in order to generate the new package version.

Thanks
Unai

@deadwards90
Copy link
Contributor Author

Noted, thanks for merging!

@deadwards90 deadwards90 deleted the ServiceBusQueueClientSingleton branch July 17, 2023 14:29
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants