Made TelemtryClient static for ApplicationInsights publisher #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 13, 2018 08:33
…elemetryConfiguration is not available yet
|
Hi @dantheman999301 Thanks for create this, let me this weekend to review all opened PR |
|
Hi @dantheman999301 I'm working on this, and I accept this PR, but for next contributions, the PR don't contain only the code, you need to increment also the version of the modified package in dependencies.props in order to create a new nuget package. |
|
Merged @dantheman999301 Appveyor is performing the build and if all is ok a new packages for application insights publisher is created with version 2.2.1 thanks for contribute on this! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst looking at the issue I raised for Service Bus, I noticed the Insights Publisher also was not kept for the lifetime of the application, so I made it only initialise once.