Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail AzureKeyVaultHealthCheck if no keys, certificates or secrets configured #1949

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

sungam3r
Copy link
Collaborator

fixes #785

@sungam3r sungam3r changed the title Fail AzureKeyVaultHealthCheck if no keys, certificates or secrets con… Fail AzureKeyVaultHealthCheck if no keys, certificates or secrets configured Jul 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1949 (8d4301c) into master (8f7d707) will increase coverage by 0.04%.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1949      +/-   ##
==========================================
+ Coverage   66.34%   66.38%   +0.04%     
==========================================
  Files         250      250              
  Lines        8643     8645       +2     
  Branches      612      613       +1     
==========================================
+ Hits         5734     5739       +5     
+ Misses       2757     2753       -4     
- Partials      152      153       +1     
Flag Coverage Δ
ArangoDb 26.66% <ø> (ø)
AzureKeyVault 21.65% <50.00%> (+2.12%) ⬆️
Consul 22.72% <ø> (ø)
EventStore 61.87% <ø> (ø)
EventStore.gRPC 25.69% <ø> (ø)
Gremlin 23.23% <ø> (ø)
RabbitMQ 48.10% <ø> (ø)
RavenDb 70.61% <ø> (ø)
Redis 66.82% <ø> (ø)
SignalR 28.28% <ø> (ø)
SqlServer 28.74% <ø> (ø)
System 37.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thChecks.AzureKeyVault/AzureKeyVaultHealthCheck.cs 15.62% <50.00%> (+5.94%) ⬆️

... and 1 file with indirect coverage changes

@sungam3r sungam3r merged commit 07d59d6 into master Jul 23, 2023
@sungam3r sungam3r deleted the azure branch July 23, 2023 06:37
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AzureKeyVault health check always returns "healthy"
2 participants