Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docker compose (consul service) #1898

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

turric4n
Copy link
Contributor

What this PR does / why we need it:

Fix docker-compose up

Which issue(s) this PR fixes:

Any

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Any

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [V ] Code compiles correctly
  • [V] Unit tests passing
  • [V] End-to-end tests passing

@sungam3r
Copy link
Collaborator

What problem does this PR fix?

@sungam3r
Copy link
Collaborator

I'm not an expert in docker and I've never used anything related to docker from that repo. I don't know the purpose of that file.

@sungam3r
Copy link
Collaborator

Also there is no CI run triggered.

@turric4n
Copy link
Contributor Author

Current docker-compose file doesn't work because consul latest image not exists. I fixed that. That should be merged asap. Thanks.

@turric4n
Copy link
Contributor Author

I'm not an expert in docker and I've never used anything related to docker from that repo. I don't know the purpose of that file.

That's ok. A Docker Compose file simplifies the orchestration of Docker services.

Here we use Docker Compose to easily set up services so that tests can utilize these services locally.

docker-compose.yml Outdated Show resolved Hide resolved
Co-authored-by: rob-baldwin <rob@bobbus.com>
@sungam3r sungam3r merged commit 41b61cc into Xabaril:master Jul 13, 2023
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants