-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive PR: Adds mechanism to prevent spam from unhealthy notifications #1877
Revive PR: Adds mechanism to prevent spam from unhealthy notifications #1877
Conversation
…tor.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…tor.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
6213275
to
99760d8
Compare
70104b9
to
640b3e3
Compare
640b3e3
to
d3b6df7
Compare
The CI seems to be flaky - |
src/HealthChecks.UI/Core/HostedService/HealthCheckReportCollector.cs
Outdated
Show resolved
Hide resolved
test/HealthChecks.UI.Tests/Functional/DatabaseProviders/SqlServerStorageProviderTests.cs
Outdated
Show resolved
Hide resolved
PR adjusted EDIT: The flaky test |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1877 +/- ##
==========================================
- Coverage 66.94% 66.76% -0.19%
==========================================
Files 228 228
Lines 8135 8163 +28
Branches 573 577 +4
==========================================
+ Hits 5446 5450 +4
- Misses 2545 2567 +22
- Partials 144 146 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/HealthChecks.UI/Core/HostedService/HealthCheckReportCollector.cs
Outdated
Show resolved
Hide resolved
src/HealthChecks.UI/Core/HostedService/HealthCheckReportCollector.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@sungam3r - you suggestions are applied now :) |
Public API has been sorted alphabetically and workflow succeeded 🎉 |
What this PR does / why we need it:
This PR revives #592
Original description:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
master
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list: