-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overload to AddAzureBlobStorage to supply your own BlobServiceClient from delegate #1845
Conversation
@dotnet-policy-service agree company="TrackMan"
… On 29 Jun 2023, at 16.56, dotnet-policy-service[bot] ***@***.***> wrote:
@willadsen <https://github.com/willadsen> please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@dotnet-policy-service agree [company="{your company}"]
Options:
(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"
Contributor License Agreement
<http://www.opensource.org/>
—
Reply to this email directly, view it on GitHub <#1845 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADGHTWEPI7UDSUGHATNPWTXNWJQ7ANCNFSM6AAAAAAZYULAP4>.
You are receiving this because you were mentioned.
|
src/HealthChecks.AzureStorage/DependencyInjection/AzureStorageHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…HealthCheckBuilderExtensions.cs
src/HealthChecks.AzureStorage/DependencyInjection/AzureStorageHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…HealthCheckBuilderExtensions.cs
src/HealthChecks.AzureStorage/DependencyInjection/AzureStorageHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…HealthCheckBuilderExtensions.cs
src/HealthChecks.AzureStorage/DependencyInjection/AzureStorageHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…HealthCheckBuilderExtensions.cs
test/HealthChecks.AzureStorage.Tests/DependencyInjection/AzureBlobStorageRegistrationTests.cs
Outdated
Show resolved
Hide resolved
…BlobStorageRegistrationTests.cs
test/HealthChecks.AzureStorage.Tests/DependencyInjection/AzureBlobStorageRegistrationTests.cs
Outdated
Show resolved
Hide resolved
…BlobStorageRegistrationTests.cs
src/HealthChecks.AzureStorage/DependencyInjection/AzureStorageHealthCheckBuilderExtensions.cs
Show resolved
Hide resolved
…HealthCheckBuilderExtensions.cs
src/HealthChecks.AzureStorage/DependencyInjection/AzureStorageHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…HealthCheckBuilderExtensions.cs
test/HealthChecks.AzureStorage.Tests/DependencyInjection/AzureBlobStorageRegistrationTests.cs
Outdated
Show resolved
Hide resolved
…BlobStorageRegistrationTests.cs
test/HealthChecks.AzureStorage.Tests/DependencyInjection/AzureBlobStorageRegistrationTests.cs
Show resolved
Hide resolved
…BlobStorageRegistrationTests.cs
test/HealthChecks.AzureStorage.Tests/DependencyInjection/AzureBlobStorageRegistrationTests.cs
Show resolved
Hide resolved
…BlobStorageRegistrationTests.cs
src/HealthChecks.AzureStorage/DependencyInjection/AzureStorageHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…HealthCheckBuilderExtensions.cs
@willadsen Thanks. I'm fine to merge after updating API approval file. |
Hi @willadsen, Are you planning to finish up this PR this week? |
Unfortunately no, as I am on vacation. It'll be a couple of weeks until I will be able to complete the PR. Feel free to complete it 😎 |
Superseded by #1889. |
BlobServiceClient
What this PR does / why we need it:
If the application needs to monitor a
BlobServiceClient
which is registered ie. using named instances (see https://learn.microsoft.com/en-us/dotnet/azure/sdk/dependency-injection)then this PR tries to solve that issue by overloading the
AddAzureBlobStorage
extension method with aFunc<IServiceProvider,BlobServiceClient>
function argument to be able to supply your own way of resolving theBlobServiceClient
instance.Which issue(s) this PR fixes:
No issue created, should I make one?
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Only if the user should wish to use these new methods
Please make sure you've completed the relevant tasks for this PR, out of the following list: