Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MySQL HealthChecks Query and Callback support. #1835

Merged
merged 15 commits into from
Jul 13, 2023

Conversation

turric4n
Copy link
Contributor

@turric4n turric4n commented Jun 6, 2023

What this PR does / why we need it:

It improves MySql Health Checks by adding Query and Callback Support.

Which issue(s) this PR fixes:

Please reference the issue this PR will close: #[issue number]

Special notes for your reviewer:

I tried to do my best mantaining original code structure.

Does this PR introduce a user-facing change?:

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [V ] Code compiles correctly
  • [ V] Created/updated tests
  • [ V] Unit tests passing
  • [ V] End-to-end tests passing
  • [ V] Extended the documentation
  • [V ] Provided sample for the feature

@github-actions github-actions bot added the mysql label Jun 6, 2023
@turric4n
Copy link
Contributor Author

turric4n commented Jun 6, 2023

@dotnet-policy-service agree [company="{your company}"]

@turric4n
Copy link
Contributor Author

turric4n commented Jun 6, 2023

@dotnet-policy-service agree

@turric4n
Copy link
Contributor Author

I can become project contributor if it necessary.

Copy link
Contributor Author

@turric4n turric4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right!

@sungam3r
Copy link
Collaborator

sungam3r commented Jul 3, 2023

@turric4n You also need to update API approval file. Just run test locally and replace old file with the new one.

@sungam3r sungam3r mentioned this pull request Jul 7, 2023
@cieciurm
Copy link
Contributor

cieciurm commented Jul 9, 2023

Hi @turric4n,

Are you planning to finish up this PR this week?
I see there is very small changes required. Perhaps you could make it? 😄

@turric4n
Copy link
Contributor Author

turric4n commented Jul 9, 2023

Indeed, I will.

@turric4n
Copy link
Contributor Author

turric4n commented Jul 11, 2023

@sungam3r @cieciurm I'm passing the tests locally. What should I do now?

@turric4n
Copy link
Contributor Author

Done! I believe I've accounted for everything.

@sungam3r
Copy link
Collaborator

@codecov-commenter
Copy link

Codecov Report

Merging #1835 (4de4788) into master (5325c5d) will increase coverage by 0.12%.
The diff coverage is 94.73%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1835      +/-   ##
==========================================
+ Coverage   66.98%   67.10%   +0.12%     
==========================================
  Files         212      213       +1     
  Lines        7744     7776      +32     
  Branches      527      529       +2     
==========================================
+ Hits         5187     5218      +31     
  Misses       2422     2422              
- Partials      135      136       +1     
Flag Coverage Δ
MySql 33.53% <94.73%> (+15.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/HealthChecks.MySql/MySqlHealthCheck.cs 90.47% <81.81%> (-2.86%) ⬇️
...encyInjection/MySqlHealthCheckBuilderExtensions.cs 100.00% <100.00%> (ø)
src/HealthChecks.MySql/MySqlHealthCheckOptions.cs 100.00% <100.00%> (ø)

@sungam3r sungam3r merged commit a19515f into Xabaril:master Jul 13, 2023
@sungam3r
Copy link
Collaborator

Thanks, @turric4n.

@turric4n
Copy link
Contributor Author

Thanks to you all, and sorry for the inconveniences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants