-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MySQL HealthChecks Query and Callback support. #1835
Conversation
@dotnet-policy-service agree [company="{your company}"] |
@dotnet-policy-service agree |
I can become project contributor if it necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right!
src/HealthChecks.MySql/DependencyInjection/MySqlHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/HealthChecks.MySql/DependencyInjection/MySqlHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/HealthChecks.MySql/DependencyInjection/MySqlHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/HealthChecks.MySql/DependencyInjection/MySqlHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
@turric4n You also need to update API approval file. Just run test locally and replace old file with the new one. |
Hi @turric4n, Are you planning to finish up this PR this week? |
Indeed, I will. |
Done! I believe I've accounted for everything. |
src/HealthChecks.MySql/DependencyInjection/MySqlHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…lderExtensions.cs
src/HealthChecks.MySql/DependencyInjection/MySqlHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…lderExtensions.cs
src/HealthChecks.MySql/DependencyInjection/MySqlHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/HealthChecks.MySql/DependencyInjection/MySqlHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1835 +/- ##
==========================================
+ Coverage 66.98% 67.10% +0.12%
==========================================
Files 212 213 +1
Lines 7744 7776 +32
Branches 527 529 +2
==========================================
+ Hits 5187 5218 +31
Misses 2422 2422
- Partials 135 136 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks, @turric4n. |
Thanks to you all, and sorry for the inconveniences. |
What this PR does / why we need it:
It improves MySql Health Checks by adding Query and Callback Support.
Which issue(s) this PR fixes:
Please reference the issue this PR will close: #[issue number]
Special notes for your reviewer:
I tried to do my best mantaining original code structure.
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list: