Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional async-chores for SMTP/IMAP health checks #1812

Merged
merged 12 commits into from
May 6, 2023
Merged

Additional async-chores for SMTP/IMAP health checks #1812

merged 12 commits into from
May 6, 2023

Conversation

peterwurzinger
Copy link
Contributor

@peterwurzinger peterwurzinger commented May 4, 2023

What this PR does / why we need it:
Some chores regarding async methods available in .NET Standard 2.0 and > .NET 5 and passing the cancellation token in operations that could potentially block as discussed in #1739 (comment)

Which issue(s) this PR fixes:
None, but related to #1738

Special notes for your reviewers:
This PR is based on branch https://github.com/peterwurzinger/AspNetCore.Diagnostics.HealthChecks/tree/fix/smtp-timeout
It doesn't make sense to base it on main, since it would result in merge conflicts, assuming that the fix in #1738 would get merged first anyways.

Does this PR introduce a user-facing change?:
No, it only introduces binary breaking changes which shouldn't be a problem according to #1739 (comment)

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Unit tests passing
  • End-to-end tests passing

@peterwurzinger peterwurzinger changed the title Feature/mail checks chores Additional async-chores for SMTP/IMAP health checks May 4, 2023
@sungam3r
Copy link
Collaborator

sungam3r commented May 5, 2023

OK, resolve conflicts and I will review.

@peterwurzinger
Copy link
Contributor Author

@sungam3r Resolved

@sungam3r sungam3r merged commit 3c787ca into Xabaril:master May 6, 2023
@sungam3r
Copy link
Collaborator

sungam3r commented May 6, 2023

Thanks.

@peterwurzinger peterwurzinger deleted the feature/mailChecks-chores branch May 6, 2023 08:01
@sungam3r
Copy link
Collaborator

sungam3r commented May 6, 2023

This PR was merged without running tests, see #1018.

@peterwurzinger
Copy link
Contributor Author

This PR was merged without running tests, see #1018.

Is there something broken or to do? I ran manual tests and unit tests against a SMTP/IMAP implementation (https://github.com/rnwood/smtp4dev), which doesn't support (STAR)TLS, but basic SMTP and IMAP functionalityand coudln't observe any errors that would not be expected.

@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants