Try fix #1712 #1805
Merged
Try fix #1712 #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
github_actions
|
@dotnet-policy-service agree |
|
@orcation Thank you very much for fix. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #1712, I found that there are two ways that may work
Modify script in src/HealthChecks.UI/package.json:
use this script
"build": "export NODE_OPTIONS=--openssl-legacy-provider && npm run build:dll && npm run build:prod"to replace the origin one
"build": "npm run build:dll && npm run build:prod"Add environment parameter in .github/workflows/healthchecks_ui_ci.yml
I personally prefer the second one because the first approach hides an environment parameter inside a script, it might be very hard to maintain, So I took the second one in this PR.
This may not be the final answer, any advice would be greatly appreciated.