Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use existing connection multiplexer for redis #1776

Conversation

Sonic198
Copy link
Contributor

What this PR does / why we need it:
According to documentation Redis connection should be reused across application.

Which issue(s) this PR fixes:
#1773

Please reference the issue this PR will close:
#[1773]

Does this PR introduce a user-facing change?:
Yes.

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ x] Code compiles correctly
  • [ x] Created/updated tests
  • [ x] Unit tests passing
  • [ x] End-to-end tests passing

@github-actions github-actions bot added the redis label Mar 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1776 (915db70) into master (2d8fcdf) will increase coverage by 14.61%.
The diff coverage is 95.83%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master    #1776       +/-   ##
===========================================
+ Coverage   51.94%   66.56%   +14.61%     
===========================================
  Files          24      145      +121     
  Lines         616     3930     +3314     
  Branches       66      390      +324     
===========================================
+ Hits          320     2616     +2296     
- Misses        282     1226      +944     
- Partials       14       88       +74     
Flag Coverage Δ
Aws.SecretsManager ?
Redis 66.82% <95.83%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/HealthChecks.Redis/RedisHealthCheck.cs 79.71% <91.66%> (ø)
...encyInjection/RedisHealthCheckBuilderExtensions.cs 100.00% <100.00%> (ø)

... and 129 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sungam3r sungam3r mentioned this pull request Mar 30, 2023
@Sonic198
Copy link
Contributor Author

Is there any problem with this PR?

@sungam3r
Copy link
Collaborator

Just a lack of time for all things. I see all the changes and follow the edits.

@esskar
Copy link
Contributor

esskar commented Apr 26, 2023

This is highly needed.

@rob-baldwin
Copy link
Contributor

LGTM

@Sonic198
Copy link
Contributor Author

Hi, any additional checks/reviews are needed to get this merged ;)?

@Sonic198
Copy link
Contributor Author

Sonic198 commented Jul 3, 2023

@sungam3r @rob-baldwin could you guys merge this, please?

@sungam3r
Copy link
Collaborator

sungam3r commented Jul 3, 2023

Will be reviewed soon and published in v7.

@sungam3r
Copy link
Collaborator

sungam3r commented Jul 5, 2023

@Sonic198 Thanks. Sometimes it so happens that review of even simple things is delayed for months. I had a break in the OSS, now I'm starting to return to the support of part of the projects that I abandoned.

@sungam3r sungam3r merged commit c5b71a4 into Xabaril:master Jul 5, 2023
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants