-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use existing connection multiplexer for redis #1776
use existing connection multiplexer for redis #1776
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1776 +/- ##
===========================================
+ Coverage 51.94% 66.56% +14.61%
===========================================
Files 24 145 +121
Lines 616 3930 +3314
Branches 66 390 +324
===========================================
+ Hits 320 2616 +2296
- Misses 282 1226 +944
- Partials 14 88 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 129 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Is there any problem with this PR? |
Just a lack of time for all things. I see all the changes and follow the edits. |
This is highly needed. |
LGTM |
Hi, any additional checks/reviews are needed to get this merged ;)? |
@sungam3r @rob-baldwin could you guys merge this, please? |
Will be reviewed soon and published in v7. |
@Sonic198 Thanks. Sometimes it so happens that review of even simple things is delayed for months. I had a break in the OSS, now I'm starting to return to the support of part of the projects that I abandoned. |
What this PR does / why we need it:
According to documentation Redis connection should be reused across application.
Which issue(s) this PR fixes:
#1773
Please reference the issue this PR will close:
#[1773]
Does this PR introduce a user-facing change?:
Yes.
Please make sure you've completed the relevant tasks for this PR, out of the following list: