add RequestTimeout as option for RavenDB healthcheck #1707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Feb 27, 2023
sungam3r
reviewed
Feb 27, 2023
|
|
||
| private class DatabaseHealthCheckCommand : RavenCommand | ||
| { | ||
| public DatabaseHealthCheckCommand() | ||
| { | ||
| Timeout = TimeSpan.FromSeconds(15); // maybe even less? |
There was a problem hiding this comment.
What is default timeout now?
sungam3r
reviewed
Feb 27, 2023
| { | ||
| _.Urls = _urls; | ||
| _.Database = "Demo"; | ||
| _.RequestTimeout = TimeSpan.Zero; |
There was a problem hiding this comment.
I would use some not-zero small value. Probably 0.5 seconds.
|
Needs fix from #1715. |
|
@schulz3000 Please rebase onto master so I can review/merge. |
Closed
6 tasks
|
Superseded by #1881. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Possibility to set a timeout for RavenDB requests
Which issue(s) this PR fixes:
Make RavenDB request timeout configurable for Healthcheck
Please reference the issue this PR will close: #1558
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list: