Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display "collections not found" text correctly #165

Merged
merged 1 commit into from
Apr 25, 2019
Merged

fix: display "collections not found" text correctly #165

merged 1 commit into from
Apr 25, 2019

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented Apr 25, 2019

No description provided.

@Odonno Odonno changed the title fix: display collections not found text correctly fix: display "collections not found" text correctly Apr 25, 2019
@Odonno
Copy link
Contributor Author

Odonno commented Apr 25, 2019

Hi @unaizorrilla

I just tested the Health Checks for Cloud Firestore. It works really well but it seems I missed one thing when the "collections not found" error happened. The text is not displayed correctly.

Thank you.

@unaizorrilla unaizorrilla merged commit 9c470fb into Xabaril:master Apr 25, 2019
@unaizorrilla
Copy link
Collaborator

Merged, a new version 2.2.0-preview-2-beta19 will be on nuget when release build finish!

Thanks!

@Odonno Odonno deleted the patch-1 branch April 25, 2019 21:36
@Odonno
Copy link
Contributor Author

Odonno commented Apr 26, 2019

And now it works like a charm. Thank you!

@Odonno
Copy link
Contributor Author

Odonno commented Apr 26, 2019

Just for you to notice but if you check the nuget website, 2.2.0-preview-2-beta19 is a previous version of 2.2.0-preview-beta19. It is so because "version number" are not based on uploaded date but on the version name.

@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants