-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elasticsearch Cluster Health Check #1577
Merged
sungam3r
merged 4 commits into
Xabaril:master
from
stefannikolei:stefannikolei/elasticsearch-cluster-health
Dec 22, 2022
Merged
Add Elasticsearch Cluster Health Check #1577
sungam3r
merged 4 commits into
Xabaril:master
from
stefannikolei:stefannikolei/elasticsearch-cluster-health
Dec 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Dec 21, 2022
...Checks.Elasticsearch/DependencyInjection/ElasticsearchClusterHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Dec 21, 2022
src/HealthChecks.Elasticsearch/ElasticsearchClusterHealthCheck.cs
Outdated
Show resolved
Hide resolved
sungam3r
requested changes
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution. I suggest to implement this feature in the existing healthcheck by providing new property in ElasticsearchOptions
like bool UseClusterHealthAPI { get; set; }
- less code.
sungam3r
reviewed
Dec 22, 2022
sungam3r
reviewed
Dec 22, 2022
sungam3r
approved these changes
Dec 22, 2022
This was referenced Jul 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second test for elasticsearch. The one implemented now just pings elastic. This one really checks the cluster health. It only respond with unhealthy when the cluster health endpoint answers with red.
Here is the documentation from elastic to this topic:
https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-health.html