NATS reconnect #1546
Merged
NATS reconnect #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosalan
reviewed
Nov 28, 2022
| // reset connection in case of stuck so the next HC call will establish it again | ||
| // https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/issues/1544 | ||
| if (connection.State == ConnState.DISCONNECTED || connection.State == ConnState.CLOSED) | ||
| _connection = null; |
There was a problem hiding this comment.
When this branch is executed (setting connection to null) then the code afterwards may throw System.NullReferenceException because it's accessing the State property in the GetHealthCheckResultFromState method.
There was a problem hiding this comment.
_connection is not connection
| if (connection == null) | ||
| { | ||
| connection = CreateConnection(_options); | ||
| var exchanged = Interlocked.CompareExchange(ref _connection, connection, null); |
There was a problem hiding this comment.
Not sure if I'm aware of the complete picture, but if CompareExchange is used to throw away connection objects created by other threads maybe double checked locking would be sufficient on the critical section that creates the connection or using Lazy<T>
There was a problem hiding this comment.
Eventually they all do the same. I prefer non-blocking APIs if applicable.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1544