-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registration methods for EventStore TCP+gRPC passing in the ServiceProvider #1538
Registration methods for EventStore TCP+gRPC passing in the ServiceProvider #1538
Conversation
test/HealthChecks.EventStore.gRPC.Tests/DependencyInjection/RegistrationTests.cs
Outdated
Show resolved
Hide resolved
…gistrationTests.cs
test/HealthChecks.EventStore.gRPC.Tests/DependencyInjection/RegistrationTests.cs
Outdated
Show resolved
Hide resolved
…gistrationTests.cs
test/HealthChecks.EventStore.gRPC.Tests/DependencyInjection/RegistrationTests.cs
Outdated
Show resolved
Hide resolved
…gistrationTests.cs
I would like to request the tags |
@carlosrecuero It looks like nuget token has expired I have no access/permissions to tune the repo settings. |
Hi @sungam3r . I'm not able to regenerate a new api key now, but i will manage it with someone else and update the secret. I will reply here as soon as i get it. Thnx. |
Hi @sungam3r , the new updated api key is set on the repository. I have re-run the build and it worked. Thank you both (+@unaizorrilla ). |
Could you also rerun the EventStore gRPC pipeline please? https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/actions/runs/3451824908 |
Done |
What this PR does / why we need it:
This will allow creation of connection string to change depending on configuration.
I also fixed a test that was green for the wrong reason, and added
TaskCreationOptions.RunContinuationsAsynchronously
to aTaskCompletionSource
. Let me know if you'd like these changes removed and/or put in a different PR.Which issue(s) this PR fixes:
Not having access to the service provider when making a connection string.
Please reference the issue this PR will close: #1531
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
No, just new overloads.
Please make sure you've completed the relevant tasks for this PR, out of the following list: