Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration methods for EventStore TCP+gRPC passing in the ServiceProvider #1538

Merged
merged 11 commits into from
Nov 11, 2022

Conversation

NielsPilgaard
Copy link
Contributor

What this PR does / why we need it:
This will allow creation of connection string to change depending on configuration.

I also fixed a test that was green for the wrong reason, and added TaskCreationOptions.RunContinuationsAsynchronously to a TaskCompletionSource. Let me know if you'd like these changes removed and/or put in a different PR.

Which issue(s) this PR fixes:
Not having access to the service provider when making a connection string.

Please reference the issue this PR will close: #1531

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

No, just new overloads.

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@NielsPilgaard NielsPilgaard changed the title Feature/eventstore factory Registration methods for EventStore TCP+gRPC passing in the ServiceProvider Nov 11, 2022
@NielsPilgaard NielsPilgaard marked this pull request as ready for review November 11, 2022 21:33
@sungam3r sungam3r merged commit 734688e into Xabaril:master Nov 11, 2022
@sungam3r sungam3r added the enhancement New feature or request label Nov 11, 2022
@NielsPilgaard NielsPilgaard deleted the feature/eventstore-factory branch November 12, 2022 12:51
@NielsPilgaard
Copy link
Contributor Author

I would like to request the tags release-eventstore-6.0.3 and release-eventstore_grpc-6.0.1 :)

@sungam3r
Copy link
Collaborator

@carlosrecuero It looks like nuget token has expired
изображение
https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/actions/runs/3451822783/jobs/5761311498

I have no access/permissions to tune the repo settings.

@carlosrecuero
Copy link
Collaborator

Hi @sungam3r . I'm not able to regenerate a new api key now, but i will manage it with someone else and update the secret. I will reply here as soon as i get it. Thnx.

@carlosrecuero
Copy link
Collaborator

Hi @sungam3r , the new updated api key is set on the repository. I have re-run the build and it worked. Thank you both (+@unaizorrilla ).

@NielsPilgaard
Copy link
Contributor Author

Could you also rerun the EventStore gRPC pipeline please? https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/actions/runs/3451824908

@sungam3r
Copy link
Collaborator

Done

@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registration methods for EventStore TCP+gRPC passing in the ServiceProvider
3 participants