Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EventStore to Build status overview #1515

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

NielsPilgaard
Copy link
Contributor

@NielsPilgaard NielsPilgaard commented Oct 30, 2022

What this PR does / why we need it:
Adds build status information about EventStore to the README

Which issue(s) this PR fixes:
None.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

No

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@NielsPilgaard NielsPilgaard marked this pull request as ready for review October 30, 2022 18:15
@NielsPilgaard
Copy link
Contributor Author

Somewhat unrelated, but how does the release flow work? Should I request a new release for the EventStore package, or submit the tag somehow?

@sungam3r sungam3r added the documentation An issue or pull request regarding documentation improvements label Oct 31, 2022
@sungam3r sungam3r merged commit e243084 into Xabaril:master Oct 31, 2022
@sungam3r
Copy link
Collaborator

One with write access to this repo pushes a tag with name like release-eventstore-6.0.3 that triggers cd pipeline. Then build process takes version from dependencies.props, builds desired project, packs it and pushes to nuget.org. Recently, I have been engaged in the publishing of releases at the request of devs.

@NielsPilgaard NielsPilgaard deleted the patch-2 branch October 31, 2022 19:31
@NielsPilgaard
Copy link
Contributor Author

In that case, I would like to request that you push a tag with the name release-eventstore-6.0.2, please 😃

@sungam3r
Copy link
Collaborator

sungam3r commented Nov 2, 2022

@NielsPilgaard
Copy link
Contributor Author

Thank you :)

@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation An issue or pull request regarding documentation improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants