-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cosmos db support #140
Conversation
Use the same version that is used in the other projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good!! Can you change the package version as I mentioned on?
build/dependencies.props
Outdated
@@ -84,6 +85,7 @@ | |||
<HealthCheckSystem>2.2.1</HealthCheckSystem> | |||
<HealthCheckNetwork>2.2.2</HealthCheckNetwork> | |||
<HealthCheckDynamoDb>2.2.0</HealthCheckDynamoDb> | |||
<HealthCheckCosmosDb>2.2.0</HealthCheckCosmosDb> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this package use preview packages, set also as preview version, 2.2.0-preview!
@unaizorrilla Great! |
Adding CosmosDb support, because documentdb will be deprecated.
I followed the same flow of documentdb and didn't delete it, so the maintainers can remove documentDb when it's officially deprecated.
I used ConnectionString instead of Uri and access token because i think it's simpler and easier to use.