Add extension for CosmosDb/TableService that accepts TokenCredential for authentication #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@levimatheri I'll merge this after fixing API approval file in tests. You need run test once, then delete ~.approved.txt file and rename ~.received.txt into ~.approved.txt. Also other tests failed. |
|
Fixed @sungam3r |
sungam3r
reviewed
Jul 3, 2022
test/HealthChecks.CosmosDb.Tests/DependencyInjection/RegistrationTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Jul 3, 2022
test/HealthChecks.CosmosDb.Tests/DependencyInjection/RegistrationTests.cs
Outdated
Show resolved
Hide resolved
|
Any chance we can get this released to nuget? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new builder extension for registering CosmosDb/TableService health check, that accepts a
TokenCredentialfor authentication using managed identities.Which issue(s) this PR fixes:
Currently we have to pass a connection string to the cosmos account, which includes the authorization key. This is not best practice in Azure, and managed identity use is recommended.
Please reference the issue this PR will close: #1298, #1134