Add API approval tests, more implicit usings, add NRT annotations, cleanup whitespaces #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eanup whitespaces
|
@carlosrecuero I merge it since there are very few actual code changes, mostly cosmetic ones. I will adress your comments into subsequent PRs if any. |
sungam3r
added
enhancement
This was referenced May 25, 2022
JGud007
reviewed
May 25, 2022
| using System.Diagnostics; | ||
| using System.Reflection; | ||
| using PublicApiGenerator; | ||
|
|
There was a problem hiding this comment.
@sungam3r Should this file be in the namespace HealthChecks.UI.Tests? Just merged this change and ran the tests using visual studio and it shows under an <Empty Namespace> heading. Not a biggie though as the test still runs/passes fine for me.
There was a problem hiding this comment.
This file is physically shared across all test projects:
<Compile Include="../ApiApprovalTests.cs" Link="ApiApprovalTests.cs" />in Directory.Build.props. So the absense of namespace is by design.
This was referenced May 25, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps to track API changes.