test: codecov for WasmHostFuncWrapper.cpp #5601
Conversation
mvadari
force-pushed
the
wrapper-unittest
branch
3 times, most recently
from
e895a97 to
41c4225
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ripple/smart-escrow #5601 +/- ##
=====================================================
+ Coverage 78.7% 78.8% +0.1%
=====================================================
Files 825 823 -2
Lines 73098 72962 -136
Branches 8548 8539 -9
=====================================================
- Hits 57553 57503 -50
+ Misses 15545 15459 -86
... and 115 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mvadari
force-pushed
the
ripple/smart-escrow
branch
from
61b2dcc to
98b8986
Compare
mvadari
force-pushed
the
wrapper-unittest
branch
from
e04bb6b to
e9563a4
Compare
|
To many changes with just refactoring which distract from actual work. Please move all the renames / refactoring to the different PR |
| @@ -1102,133 +1237,4 @@ class MockInstanceWrapper | |||
| } | |||
| }; | |||
|
|
|||
| namespace test { | |||
| bool | |||
| testGetDataIncrement() | |||
There was a problem hiding this comment.
I removed it, since the existing tests now give us full code coverage.
There was a problem hiding this comment.
Which test check for correct index increment?
There was a problem hiding this comment.
Several of the tests would fail if the index increment was wrong.
There was a problem hiding this comment.
As from our previous experience this error will be hard to find from just test failed. Better leave it
There was a problem hiding this comment.
Ok, brought it back but excluded it from codecov
mvadari
force-pushed
the
wrapper-unittest
branch
from
e9563a4 to
fe7e924
Compare
moved to #5609 |
| { | ||
| return Bytes(accountID_.begin(), accountID_.end()); | ||
| } | ||
| } | ||
| uint8_t const a[] = {0x2b, 0x6a, 0x23, 0x2a, 0xa4, 0xc4, 0xbe, 0x41, |
There was a problem hiding this comment.
How were these test data values created?
There was a problem hiding this comment.
I think that was @oleks-rip. Either way, IMO out of scope of this PR.
This reverts commit e3beb9b.
High Level Overview of Change
This PR adds WASM tests to get 100% codecov on
WasmHostFuncWrapper.cppContext of Change
better testing
Type of Change
.gitignore, formatting, dropping support for older tooling)Test Plan
Added WASM tests to cover all the code.
Rust code is here: ripple/craft#111