-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add other misc host functions #5574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mvadari
wants to merge
15
commits into
XRPLF:ripple/smart-escrow
Choose a base branch
from
mvadari:other-hf
base: ripple/smart-escrow
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+477
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c411f98
to
c284907
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ripple/smart-escrow #5574 +/- ##
=====================================================
- Coverage 78.7% 78.6% -0.1%
=====================================================
Files 823 823
Lines 73030 73179 +149
Branches 8604 8684 +80
=====================================================
+ Hits 57486 57495 +9
- Misses 15544 15684 +140
🚀 New features to boost your workflow:
|
61b2dcc
to
98b8986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds the remaining misc host functions listed in XLS-102d and adds amendment checks for the keylet functions.
Context of Change
Full list of host functions: XRPLF/XRPL-Standards#279
Type of Change