Skip to content

feat: add other misc host functions #5574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: ripple/smart-escrow
Choose a base branch
from

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Jul 16, 2025

High Level Overview of Change

This PR adds the remaining misc host functions listed in XLS-102d and adds amendment checks for the keylet functions.

Context of Change

Full list of host functions: XRPLF/XRPL-Standards#279

Type of Change

  • New feature (non-breaking change which adds functionality)

@mvadari mvadari force-pushed the other-hf branch 3 times, most recently from c411f98 to c284907 Compare July 16, 2025 19:44
@mvadari mvadari marked this pull request as ready for review July 16, 2025 20:04
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 6.71141% with 139 lines in your changes missing coverage. Please review.

Project coverage is 78.6%. Comparing base (98b8986) to head (e5551a2).

Files with missing lines Patch % Lines
src/xrpld/app/misc/WasmHostFuncWrapper.cpp 0.0% 87 Missing ⚠️
src/xrpld/app/misc/WasmHostFuncImpl.cpp 0.0% 30 Missing ⚠️
src/xrpld/app/misc/WasmHostFunc.h 0.0% 22 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           ripple/smart-escrow   #5574     +/-   ##
=====================================================
- Coverage                 78.7%   78.6%   -0.1%     
=====================================================
  Files                      823     823             
  Lines                    73030   73179    +149     
  Branches                  8604    8684     +80     
=====================================================
+ Hits                     57486   57495      +9     
- Misses                   15544   15684    +140     
Files with missing lines Coverage Δ
src/xrpld/app/misc/WasmHostFuncImpl.h 100.0% <ø> (ø)
src/xrpld/app/misc/WasmVM.cpp 97.5% <100.0%> (+0.4%) ⬆️
src/xrpld/app/misc/WasmHostFunc.h 3.1% <0.0%> (-0.9%) ⬇️
src/xrpld/app/misc/WasmHostFuncImpl.cpp 58.0% <0.0%> (-5.1%) ⬇️
src/xrpld/app/misc/WasmHostFuncWrapper.cpp 72.1% <0.0%> (-11.5%) ⬇️

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mvadari mvadari force-pushed the ripple/smart-escrow branch from 61b2dcc to 98b8986 Compare July 24, 2025 13:21
@mvadari
Copy link
Collaborator Author

mvadari commented Jul 24, 2025

Lightly blocked by #5578 and #5601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant