Pre-lending protocol refactoring 1: Misc

[ximinez]

High Level Overview of Change

This PR is one of four which contain several small changes that are used as the baseline of #5270. Since they are significant and useful, I created this separate PR to get them merged sooner.

(It's not a pure refactor as some new minor functionality has been introduced.)

Context of Change

#5270 is large and complicated, and I had to lay some groundwork before I could implement the feature.

Type of Change

• New feature (non-breaking change which adds functionality)
• Refactor (non-breaking change that only restructures code)
• Tests (you added tests for code that already exists, or your new feature included in this PR)

Before / After

Highlights:

• to_short_string(base_uint). Like to_string, but only returns the first 8 characters. (Similar to how a git commit ID can be abbreviated.) Used as a wrapped sink to prefix most transaction-related messages. More can be added later.
• XRPL_ASSERT_PARTS. Convenience wrapper for XRPL_ASSERT, which takes the function and description as separate parameters.
• SField::sMD_PseudoAccount. Metadata option for SField definitions to indicate that the field, if set in an AccountRoot indicates that account is a pseudo-account. Removes the need for hard-coded field lists all over the place. Added the flag to AMMID and VaultID.
• Added functionality to SField ctor to detect both code and name collisions using asserts.
• Convenience type aliases STLedgerEntry::const_pointer and STLedgerEntry::const_ref. (SLE is an alias to STLedgerEntry.)
• Generalized feeunit.h (TaggedFee) into unit.h (ValueUnit) and added new "BIPS"-related tags for future use.
• Restructured transactions.macro to do two big things
  1. Include the #include directives for transactor header files directly in the macro file. Removes the need to update applySteps.cpp and the resulting conflicts.
  2. Added a privileges parameter to the TRANSACTION macro, which specifies some of the operations a transaction is allowed to do. These privileges are enforced by invariant checks. Again, removed the need to update scattered lists of transaction types in various checks.
• Unit tests:
  1. Moved more helper functions into TestHelpers.h and .cpp.
  2. Cleaned up the namespaces to prevent / mitigate random collisions and ambiguous symbols, particularly in unity builds.
  3. Generalized Env::balance to add support for MPTIssue and Asset.
  4. Added a set of helper classes to simplify Env transaction parameter classes: JTxField, JTxFieldWrapper, and a bunch of classes derived or aliased from it. For an example of how awesome it is, check the changes src/test/jtx/escrow.h for how much simpler the definitions are for finish_time, cancel_time, condition, and fulfillment.
  5. Generalized several of the amount-related helper classes to understand Assets.
• Added a new Invariant: ValidPseudoAccounts which checks that all pseudo-accounts behave consistently through creation and updates, and that no "real" accounts look like pseudo-accounts (which means they don't have a 0 sequence).

[codecov]

Codecov Report

❌ Patch coverage is 87.82609% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.8%. Comparing base (7179ce9) to head (66dd0de).

Files with missing lines	Patch %	Lines
src/xrpld/ledger/detail/View.cpp	48.9%	23 Missing ⚠️
src/xrpld/app/tx/detail/InvariantCheck.cpp	95.2%	3 Missing ⚠️
include/xrpl/protocol/Units.h	95.5%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5590     +/-   ##
=========================================
- Coverage     78.8%   78.8%   -0.0%     
=========================================
  Files          814     814             
  Lines        71259   71339     +80     
  Branches      8345    8373     +28     
=========================================
+ Hits         56162   56190     +28     
- Misses       15097   15149     +52     

Files with missing lines	Coverage Δ
include/xrpl/basics/base_uint.h	96.9% <100.0%> (+<0.1%)	⬆️
include/xrpl/protocol/SField.h	100.0% <ø> (ø)
include/xrpl/protocol/STLedgerEntry.h	100.0% <ø> (ø)
include/xrpl/protocol/STObject.h	93.1% <ø> (ø)
include/xrpl/protocol/STValidation.h	69.5% <ø> (ø)
include/xrpl/protocol/XRPAmount.h	98.9% <ø> (ø)
include/xrpl/protocol/detail/transactions.macro	100.0% <100.0%> (ø)
src/libxrpl/protocol/Permissions.cpp	95.3% <ø> (ø)
src/libxrpl/protocol/SField.cpp	83.0% <100.0%> (+1.6%)	⬆️
src/libxrpl/protocol/TxFormats.cpp	100.0% <ø> (ø)
... and 11 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.