-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Switching some unit tests to doctest #5383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Happy to help with this as I can. Will take a look this evening. Please communicate with me here if there's something you'd like to ask. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5383 +/- ##
=========================================
- Coverage 78.1% 78.1% -0.0%
=========================================
Files 795 794 -1
Lines 68598 68498 -100
Branches 8278 8277 -1
=========================================
- Hits 53593 53495 -98
+ Misses 15005 15003 -2 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests build and pass on my machine. 👍
@@ -116,6 +117,7 @@ def requirements(self): | |||
'external/*', | |||
'include/*', | |||
'src/*', | |||
'tests/*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is no longer needed if you're using src/tests
instead of tests
. I still recommend tests
as a matter of convention.
High Level Overview of Change
This PR is continuation of work done by @thejohnfreeman. We intend to move from our unit tests framework to doctest.
Context of Change
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)