Skip to content

libinput: option tapping by default enabled #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libinput: option tapping by default enabled #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/xf86libinput.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5641,7 +5641,8 @@ LibinputInitTapProperty(DeviceIntPtr dev,
struct xf86libinput *driver_data,
struct libinput_device *device)
{
BOOL tap = driver_data->options.tapping;
// By default tapping property config is true
BOOL tap = driver_data->options.tapping ? driver_data->options.tapping : TRUE;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(x ? x : TRUE) == TRUE for all values of x.
Are you sure this is right?
Can this be later turned off?
If this is right, why not just Book tap = TRUE;?

Copy link
Contributor

@dec05eba dec05eba Jul 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct way to set the default value. This just ignores the value the user sets in the config file. The default value should be set in xf86libinput_parse_tap_option. Take a look at how it's done in xf86libinput_parse_scroll_pixel_distance_option. I dont have a laptop anymore so I cant do any of that myself. The default value for line 5663 also needs to be changed as well in the same way.


if (!subdevice_has_capabilities(dev, CAP_POINTER))
return;
Expand Down