libinput: option tapping by default enabled #7
Conversation
GermanAizek
force-pushed
the
fix-tap-touchpad-enabled-default
branch
2 times, most recently
from
6911434 to
9a5c471
Compare
This fix helps most laptop users not to change properties in config. Issue: X11Libre#6 Signed-off-by: Herman Semenov <GermanAizek@yandex.ru>
GermanAizek
force-pushed
the
fix-tap-touchpad-enabled-default
branch
from
9a5c471 to
2c360d5
Compare
metux
requested review from
mikedld,
callmetango,
stefan11111,
steven-vd,
dec05eba and
artist4xlibre
| { | ||
| BOOL tap = driver_data->options.tapping; | ||
| // By default tapping property config is true | ||
| BOOL tap = driver_data->options.tapping ? driver_data->options.tapping : TRUE; |
There was a problem hiding this comment.
This is not the correct way to set the default value. This just ignores the value the user sets in the config file. The default value should be set in xf86libinput_parse_tap_option. Take a look at how it's done in xf86libinput_parse_scroll_pixel_distance_option. I dont have a laptop anymore so I cant do any of that myself. The default value for line 5663 also needs to be changed as well in the same way.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
| { | ||
| BOOL tap = driver_data->options.tapping; | ||
| // By default tapping property config is true | ||
| BOOL tap = driver_data->options.tapping ? driver_data->options.tapping : TRUE; |
There was a problem hiding this comment.
(x ? x : TRUE) == TRUE for all values of x.
Are you sure this is right?
Can this be later turned off?
If this is right, why not just Book tap = TRUE;?
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@GermanAizek @dec05eba @artist4xlibre @stefan11111 The default value for "Tapping" comes from |
|
If possible, please verify whether a file solves the issue. If it is so, we could add this file permanently to input-libinput. |
|
@artist4xlibre |
@metux,
This fix helps most laptop users not to change properties in config.
Issue: #6