backport per-block custom CSS changes#3977
Closed
aristath wants to merge 4 commits intoWordPress:trunkfrom
Closed
Conversation
Mamaduka
reviewed
Feb 3, 2023
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @aristath, Left nit-pick feedback.
Comment on lines
1013
to
1015
| * @param string $selector The selector to nest. | ||
| * | ||
| * @return string The processed CSS. |
Member
There was a problem hiding this comment.
Suggested change
| * @param string $selector The selector to nest. | |
| * | |
| * @return string The processed CSS. | |
| * @param string $selector The selector to nest. | |
| * @return string The processed CSS. |
Member
|
It looks like we missed the undefined method usage in #3896. This PR should fix that. |
felixarntz
approved these changes
Feb 3, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
🤦 for missing this
@aristath Great catch, thanks for the fix!
Member
|
Committed in https://core.trac.wordpress.org/changeset/55216 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports WordPress/gutenberg#46571
This is a continuation of #3896
That PR included a call to the
process_blocks_custom_cssmethod, but the method itself was not included.This PR back ports that method, and its related tests.
Trac ticket: https://core.trac.wordpress.org/ticket/57621
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.