Make process_blocks_custom_css method protected#47725
Merged
Conversation
aristath
added
the
Backport to WP 6.9 Beta/RC
Member
|
There's no need to backport since changes are already handled in core PR 👍 |
Mamaduka
added
[Type] Task
|
Flaky tests detected in 23ea2a6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4082417266
|
Mamaduka
approved these changes
Feb 3, 2023
Member
|
Thanks for following up |
juanmaguitar
added
the
[Type] Code Quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Following the comments on #46571 (comment) and WordPress/wordpress-develop#3977 (comment), this PR changes the visibility of the
process_blocks_custom_cssfrompublictoprotected.Why?
To avoid exposing the method publicly
How?
Changed the visibility of the method, and then used
ReflectionMethodin PHPUnit tests.Testing Instructions
Nothing to test. If PHP tests pass, this is good to go.