Default palette & gradients are opt-out for themes with theme.json#1971
Closed
oandregal wants to merge 1 commit intoWordPress:trunkfrom
oandregal:fix/default-palette-core
Closed
Default palette & gradients are opt-out for themes with theme.json#1971oandregal wants to merge 1 commit intoWordPress:trunkfrom oandregal:fix/default-palette-core
theme.json#1971oandregal wants to merge 1 commit intoWordPress:trunkfrom
oandregal:fix/default-palette-core
Conversation
This was referenced Nov 29, 2021
Member
Author
|
Closing this in favor of #1973 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that we've missed backporting some changes from WordPress/gutenberg#36622 in this backport #1928
Specifically, we've missed the changes to WordPress core
theme.jsonfile, which includes the defaults. As a result, themes withtheme.jsonwon't see the default palette & gradients.How to test
The expected result is that the color panel shows colors from the default and theme palettes. In
trunkit only shows the theme palette.