Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeouts to visual regression, e2e tests, and storybook generation #796

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Add timeouts to visual regression, e2e tests, and storybook generation #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b12fa6c
Add timeouts to visual regression, e2e tests, and storybook generation
zackkrida Feb 28, 2023
5ec42e0
Add the ci_cd workflow to the file filters
zackkrida Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/filters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
api:
- .github/workflows/ci_cd.yml
- api/**
ingestion_server:
- .github/workflows/ci_cd.yml
- ingestion_server/**
frontend:
- .github/workflows/ci_cd.yml
- frontend/**
- package.json
- pnpm-lock.yaml
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci_cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,7 @@ jobs:
name: Nuxt Playwright e2e tests
if: needs.get-changes.outputs.frontend == 'true'
runs-on: ubuntu-latest
timeout-minutes: 15
needs:
- get-changes
- lint
Expand Down Expand Up @@ -513,6 +514,7 @@ jobs:
name: Nuxt Playwright VR tests
if: needs.get-changes.outputs.frontend == 'true'
runs-on: ubuntu-latest
timeout-minutes: 15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test takes ~12 min so 15 min might be cutting it close. Maybe a higher limit like 20 min might be more appropriate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12 is the max I've seen, with as low as 7. Could we keep this as-is and increase in future PRs which increase the duration?

needs:
- get-changes
- lint
Expand Down Expand Up @@ -541,6 +543,7 @@ jobs:
name: Storybook Playwright tests
if: needs.get-changes.outputs.frontend == 'true'
runs-on: ubuntu-latest
timeout-minutes: 15
needs:
- get-changes
- lint
Expand Down