-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeouts to visual regression, e2e tests, and storybook generation #796
Conversation
Full-stack documentation: Ready https://WordPress.github.io/openverse/_preview/796 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @zackkrida could you add .github/workflows/ci_cd.yml
to the filters (https://github.com/WordPress/openverse/blob/de8a078374da546479bf534784104dfb671a222f/.github/filters.yml) for all 3 packages so that the complete CI is triggered and we can verify that 15m is enough for the tests to run completely?
@@ -513,6 +514,7 @@ jobs: | |||
name: Nuxt Playwright VR tests | |||
if: needs.get-changes.outputs.frontend == 'true' | |||
runs-on: ubuntu-latest | |||
timeout-minutes: 15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test takes ~12 min so 15 min might be cutting it close. Maybe a higher limit like 20 min might be more appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12 is the max I've seen, with as low as 7. Could we keep this as-is and increase in future PRs which increase the duration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* _-prefix methods that should not be overridden * Initial template * Add initial docs * Update template, add test template file * Add script to generate template files * Update docs to reference script * Moving more documentation into the code * Reformat docs - Breaks out into several files - Removes documentation that is redundant (copied from code) - Prefers documentation within the template - Explicitly documents advanced options as FAQ - Some small updates to the templating * Small tweaks * Remove unused 'license_url' from nappy and comment out unused test imports * Remove unused 'license_url' from nappy and comment out unused test imports * write small helper fn for filesizes * Add UA string header * move thumbnail_url to metadata for now * rename thumbnail_url metadata field to thumbnail * add dag start date * no header in next params & add thumbnail_url * add tests and test resources * remove questionable tag from test image * update docs * add popularity metrics to metadata * Add url to source docs Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu> * remove template comment from next query params Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu> * remove template comment on optional fields Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu> * remove template comment on get batch Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu> * remove template comment from main Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu> * remove template comment from get_record_data Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu> * pass batch_limit to the API Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu> * tests for batch limit API parameter * point to popularity metrics * template test directory fix * make license info a class variable * Remove outdated/duplicated template creation files * Update DAG documentation * fortify and test convert filesize Co-authored-by: Staci Cooper <staci.cooper@automattic.com> Co-authored-by: rwidom <rebeccawidom@gmail.com> Co-authored-by: rwidom <rwidom@users.noreply.github.com> Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
Fixes
Fixes #795 by @dhruvkb
Description
Adds a 15 minute timeout to playwright tests, e2e tests, and storybook doc generation. This should be a sensible default timeout that leaves space for successful runs to complete.
Testing Instructions
Checklist
Update index.md
).main
) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin