Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add tags page text #4549

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Re-add tags page text #4549

merged 1 commit into from
Jun 26, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jun 25, 2024

Fixes

Fast-follow to #4291

Description

#4442 that added the tags page copy text was merged into #4291, but when I used the GitHub UI to rebase the branch onto main before merging it, the merged PR changes disappeared. This PR re-adds the changes from #4442.

Setting the priority to high because this affects the strings sent to translators. We can deploy prod again after this PR is merged to speed up the translator strings updates.

Testing Instructions

Run the app using just frontend/run dev (or just frontend/run i18n:en and just frontend/run dev:only if you don't want to download all locales)
Go to http://localhost:8443/search?q=cat and select the second image result.
There should be a "generated tags" section. Click on "Learn more" next to the heading. It should contain correct text (the prod currently has a very short sentence originally used as a stub)

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (./ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (./ov just catalog/generate-docs media-props
    for the catalog or ./ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 📄 aspect: text Concerns the textual material in the repository 🧱 stack: frontend Related to the Nuxt frontend labels Jun 25, 2024
@obulat obulat requested a review from a team as a code owner June 25, 2024 04:13
Signed-off-by: Olga Bulat <obulat@gmail.com>
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the tags page is accessible as expected and that the new text renders!

@obulat obulat merged commit 3e76e4b into main Jun 26, 2024
47 checks passed
@obulat obulat deleted the fix/tags-page branch June 26, 2024 07:07
},
sourceTags: {
title: "Source Tags",
/** sourceTags.content.a-b are parts of a single section explaining how source tags work in Openverse. */
Copy link
Collaborator

@sarayourfriend sarayourfriend Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obulat heads up that these comments will not appear in the generated pot file, only comments on the string properties themselves do. I have a small patch I was working on that might fix this though, because it would be nice if this just worked!

Update: I've created an issue for this #4565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants