Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags page copy #4442

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Tags page copy #4442

merged 2 commits into from
Jun 11, 2024

Conversation

zackkrida
Copy link
Member

@zackkrida zackkrida commented Jun 5, 2024

Fixes

Fixes #4379 by @obulat

Description

This PR adds copy to the generated tags page. It also renames the page to "Tags". @obulat feel free to merge this into your PR for review there, or reviewers can verify the copy here first if preferred.

Testing instructions

  1. Run just f to start the frontend
  2. Navigate to http://localhost:8443/tags and check the copy/formatting

@zackkrida zackkrida requested a review from a team as a code owner June 5, 2024 19:02
@zackkrida zackkrida changed the title Display generated tags separately Tags page copy Jun 5, 2024
@github-actions github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label Jun 5, 2024
@openverse-bot openverse-bot added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🏷 status: label work required Needs proper labelling before it can be worked on labels Jun 5, 2024
@zackkrida zackkrida requested review from obulat and removed request for dhruvkb June 5, 2024 20:18
@zackkrida
Copy link
Member Author

Oops, I'll fix the string lengths tomorrow. Please review for the content itself in the meantime 😄

@obulat obulat added 🌟 goal: addition Addition of new feature 📄 aspect: text Concerns the textual material in the repository 🟧 priority: high Stalls work on the project or its dependents and removed 🏷 status: label work required Needs proper labelling before it can be worked on 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jun 6, 2024
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few notes on wording!

intro: {
content: "Generated tags are automatically assigned to media items based on the content of the media item itself. These tags are generated using machine learning models trained on a large dataset of images and audio tracks.",
a: "Each creative work in {openverse} includes tags, an optional set of keywords used to describe the work and make it easier for users to find what they are looking for.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be "may have tags" instead of "include tags", since the latter makes it seem like each record will have tags (even though it says optional right after that).

intro: {
content: "Generated tags are automatically assigned to media items based on the content of the media item itself. These tags are generated using machine learning models trained on a large dataset of images and audio tracks.",
a: "Each creative work in {openverse} includes tags, an optional set of keywords used to describe the work and make it easier for users to find what they are looking for.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording suggestion:

Suggested change
a: "Each creative work in {openverse} includes tags, an optional set of keywords used to describe the work and make it easier for users to find what they are looking for.",
a: "Each creative work in {openverse} includes tags, an optional set of keywords used to describe the work and make it easier for users to find relevant media for their searches.",

},
sourceTags: {
title: "Source Tags",
content: "Source tags are tags that originate from the original source of the creative work. These tags may be added by different contributors, for example a photographer who uploaded their image to Flickr and added descriptive tags. Additionally, the source platform itself may assign additional tags from community members, or automation.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording nit:

Suggested change
content: "Source tags are tags that originate from the original source of the creative work. These tags may be added by different contributors, for example a photographer who uploaded their image to Flickr and added descriptive tags. Additionally, the source platform itself may assign additional tags from community members, or automation.",
content: "Source tags are tags that originate from the original source of the creative work. These tags may be added by different contributors, for example a photographer who uploaded their image to Flickr and added descriptive tags. The original platform itself may assign additional tags from community members, automation, or other sources.",

@openverse-bot
Copy link
Collaborator

Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR:

@obulat
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was ready for review 3 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2.

@zackkrida, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday.

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat
Copy link
Contributor

obulat commented Jun 11, 2024

I added the suggestions and fixed the line lengths. I'm going to merge this PR into #4291

@obulat obulat merged commit dc6dd3f into add/generated-tags-display Jun 11, 2024
43 checks passed
@obulat obulat deleted the tags-page-copy branch June 11, 2024 10:22
@obulat obulat mentioned this pull request Jun 25, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 aspect: text Concerns the textual material in the repository 🌟 goal: addition Addition of new feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants