-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tags page copy #4442
Tags page copy #4442
Conversation
Oops, I'll fix the string lengths tomorrow. Please review for the content itself in the meantime 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few notes on wording!
intro: { | ||
content: "Generated tags are automatically assigned to media items based on the content of the media item itself. These tags are generated using machine learning models trained on a large dataset of images and audio tracks.", | ||
a: "Each creative work in {openverse} includes tags, an optional set of keywords used to describe the work and make it easier for users to find what they are looking for.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be "may have tags" instead of "include tags", since the latter makes it seem like each record will have tags (even though it says optional right after that).
intro: { | ||
content: "Generated tags are automatically assigned to media items based on the content of the media item itself. These tags are generated using machine learning models trained on a large dataset of images and audio tracks.", | ||
a: "Each creative work in {openverse} includes tags, an optional set of keywords used to describe the work and make it easier for users to find what they are looking for.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording suggestion:
a: "Each creative work in {openverse} includes tags, an optional set of keywords used to describe the work and make it easier for users to find what they are looking for.", | |
a: "Each creative work in {openverse} includes tags, an optional set of keywords used to describe the work and make it easier for users to find relevant media for their searches.", |
}, | ||
sourceTags: { | ||
title: "Source Tags", | ||
content: "Source tags are tags that originate from the original source of the creative work. These tags may be added by different contributors, for example a photographer who uploaded their image to Flickr and added descriptive tags. Additionally, the source platform itself may assign additional tags from community members, or automation.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording nit:
content: "Source tags are tags that originate from the original source of the creative work. These tags may be added by different contributors, for example a photographer who uploaded their image to Flickr and added descriptive tags. Additionally, the source platform itself may assign additional tags from community members, or automation.", | |
content: "Source tags are tags that originate from the original source of the creative work. These tags may be added by different contributors, for example a photographer who uploaded their image to Flickr and added descriptive tags. The original platform itself may assign additional tags from community members, automation, or other sources.", |
Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR: @obulat Excluding weekend1 days, this PR was ready for review 3 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2. @zackkrida, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
Signed-off-by: Olga Bulat <obulat@gmail.com>
I added the suggestions and fixed the line lengths. I'm going to merge this PR into #4291 |
Fixes
Fixes #4379 by @obulat
Description
This PR adds copy to the generated tags page. It also renames the page to "Tags". @obulat feel free to merge this into your PR for review there, or reviewers can verify the copy here first if preferred.
Testing instructions
just f
to start the frontend