-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes all sensible occurrences of the just commands to have them run using ov #4483
Changes all sensible occurrences of the just commands to have them run using ov #4483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating all these references! There a few that should be left as-is, I've noted them inline.
It seems like we may also need to change references that are in code blocks (in addition to the inline preformatted code sections)! |
I've updated the code blocks. In the end I had to go through them manually but it should now be all of them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some very small details that are hard to see and very easy to miss without a lot more context about ov
and the repository in general.
Thanks for all the detailed work thus far 🙏
catalog/tests/dags/providers/provider_api_scripts/test_cc_mixter.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Even if there are issues we've missed here or there, I think this is at least an excellent foundation to continue iteration on.
Thanks for the contribution @szymon-polaczy 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this work, @szymon-polaczy!
Requested changes were fixed and/or captured in a new issue.
Fixes
Fixes #4482 by @dhruvkb
Description
I've changed all occurrences of the just commands so that they have the ./ov at the beginning - I didn't update changelogs, proposals and scripts
Checklist
Update index.md
).main
) or a parent feature branch.just catalog/generate-docs
for catalogPRs) or the media properties generator (
just catalog/generate-docs media-props
for the catalog or
just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin