Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes all sensible occurrences of the just commands to have them run using ov #4483

Merged

Conversation

szymon-polaczy
Copy link
Contributor

Fixes

Fixes #4482 by @dhruvkb

Description

I've changed all occurrences of the just commands so that they have the ./ov at the beginning - I didn't update changelogs, proposals and scripts

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (just catalog/generate-docs for catalog
    PRs) or the media properties generator (just catalog/generate-docs media-props
    for the catalog or just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@szymon-polaczy szymon-polaczy requested review from a team as code owners June 13, 2024 12:47
@openverse-bot openverse-bot added 🧱 stack: catalog Related to the catalog and Airflow DAGs 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend 🧱 stack: mgmt Related to repo management and automations 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature 📄 aspect: text Concerns the textual material in the repository labels Jun 13, 2024
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating all these references! There a few that should be left as-is, I've noted them inline.

documentation/catalog/guides/deploy.md Outdated Show resolved Hide resolved
documentation/meta/maintenance/elasticsearch_cluster.md Outdated Show resolved Hide resolved
frontend/justfile Outdated Show resolved Hide resolved
@AetherUnbound
Copy link
Collaborator

It seems like we may also need to change references that are in code blocks (in addition to the inline preformatted code sections)!

@szymon-polaczy
Copy link
Contributor Author

It seems like we may also need to change references that are in code blocks (in addition to the inline preformatted code sections)!

I've updated the code blocks. In the end I had to go through them manually but it should now be all of them

Copy link
Collaborator

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some very small details that are hard to see and very easy to miss without a lot more context about ov and the repository in general.

Thanks for all the detailed work thus far 🙏

catalog/templates/template_test.py_template Outdated Show resolved Hide resolved
documentation/catalog/guides/quickstart.md Outdated Show resolved Hide resolved
documentation/frontend/guides/quickstart.md Outdated Show resolved Hide resolved
documentation/general/quickstart.md Outdated Show resolved Hide resolved
utilities/load_testing/README.md Outdated Show resolved Hide resolved
utilities/load_testing/README.md Outdated Show resolved Hide resolved
utilities/load_testing/README.md Outdated Show resolved Hide resolved
utilities/load_testing/README.md Outdated Show resolved Hide resolved
utilities/load_testing/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Even if there are issues we've missed here or there, I think this is at least an excellent foundation to continue iteration on.

Thanks for the contribution @szymon-polaczy 🙏

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this work, @szymon-polaczy!

@zackkrida zackkrida dismissed AetherUnbound’s stale review June 18, 2024 20:08

Requested changes were fixed and/or captured in a new issue.

@zackkrida zackkrida merged commit 79c3a67 into WordPress:main Jun 18, 2024
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 aspect: text Concerns the textual material in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: catalog Related to the catalog and Airflow DAGs 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update references to our developer tools to have the ./ov prefix
5 participants