Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always remove containers when using just run #4171

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Conversation

AetherUnbound
Copy link
Collaborator

Description

I kept finding containers that had been left exited but not removed from my system. Recent investigation led me to find that it was the catalog's generate-docs recipe, which hadn't added the --rm. There isn't a case where we really care to keep the containers after running something with just run, so I've removed the instances where we were explicitly calling --rm and moved it to the top level just run recipe. Now containers will be removed by default and we don't have to declare it for every new recipe which uses just run!

Testing Instructions

Run just catalog/generate-docs and then docker ps -a and observe that the container which got started to run the documentation generation no longer exists.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound added the 🟩 priority: low Low priority and doesn't need to be rushed label Apr 19, 2024
@AetherUnbound AetherUnbound requested a review from a team as a code owner April 19, 2024 20:55
@AetherUnbound AetherUnbound added 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Apr 19, 2024
@obulat obulat removed the request for review from fcoveram April 20, 2024 03:25
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I did container cleanup several times recently :)

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, LGTM!

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! I noticed those dangling container lately as well and was planing about doing the 🕵️ work. Glad that you already find a solution! 💯

@krysal krysal merged commit 0ed4071 into main Apr 20, 2024
66 checks passed
@krysal krysal deleted the fix/container-gen-rm branch April 20, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants