Always remove containers when using just run
#4171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I kept finding containers that had been left exited but not removed from my system. Recent investigation led me to find that it was the catalog's
generate-docs
recipe, which hadn't added the--rm
. There isn't a case where we really care to keep the containers after running something withjust run
, so I've removed the instances where we were explicitly calling--rm
and moved it to the top leveljust run
recipe. Now containers will be removed by default and we don't have to declare it for every new recipe which usesjust run
!Testing Instructions
Run
just catalog/generate-docs
and thendocker ps -a
and observe that the container which got started to run the documentation generation no longer exists.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin