Skip to content

Commit

Permalink
Always remove containers when using just run (#4171)
Browse files Browse the repository at this point in the history
  • Loading branch information
AetherUnbound authored Apr 20, 2024
1 parent b29c6a9 commit 0ed4071
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions catalog/justfile
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ shell:
# Launch an IPython shell in a new container under `SERVICE`
ipython *args: up-deps
env DC_USER="airflow" just ../run \
--rm \
--workdir /opt/airflow/catalog/dags \
{{ SERVICE }} \
bash -c \'ipython {{ args }}\'
Expand All @@ -100,7 +99,6 @@ pgcli db_user_pass="deploy" db_name="openledger": up
# Run a command in a test container under `SERVICE`
_mount-test command: up-deps
env DC_USER="airflow" just ../run \
--rm \
-e AIRFLOW_VAR_INGESTION_LIMIT=1000000 \
-w /opt/airflow/catalog \
--volume \'{{ justfile_directory() }}/../docker\':/opt/airflow/docker/ \
Expand Down
2 changes: 1 addition & 1 deletion justfile
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ exec +args:
# Execute statement in a new service container using Docker Compose
run +args:
just dc run -u {{ env_var_or_default("DC_USER", "root") }} {{ EXEC_DEFAULTS }} "{{ args }}"
just dc run --rm -u {{ env_var_or_default("DC_USER", "root") }} {{ EXEC_DEFAULTS }} "{{ args }}"
# Execute pgcli against one of the database instances
_pgcli container db_user_pass db_name db_host db_port="5432":
Expand Down

0 comments on commit 0ed4071

Please sign in to comment.