Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ralph Rinzler Folklife Archives and Collections to Smithsonian subproviders #3787

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

stacimc
Copy link
Contributor

@stacimc stacimc commented Feb 12, 2024

Fixes

Fixes alert in production.

Description

This PR adds the Ralph Rinzler Folklife Archives and Collections subprovider to the Smithsonian DAG, as prompted by the validate_unit_codes_from_api step which recently alerted in production.

Testing Instructions

Run the Smithsonian DAG on main and see that it fails immediately with the error:

Updates needed to the SMITHSONIAN_SUB_PROVIDERS dictionary*:
New unit codes must be added:

  • CFCHFOLKLIFE

Check out this branch and run the DAG again and see that it passes that step and begins ingesting records.

Note that after the next run of the Smithsonian DAG in production we should check the count of records with this subprovider, and enable the source in production Django admin if there are sufficient records.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@stacimc stacimc added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Feb 12, 2024
@stacimc stacimc self-assigned this Feb 12, 2024
@stacimc stacimc requested a review from a team as a code owner February 12, 2024 18:39
@AetherUnbound AetherUnbound changed the title Add Ralph Rinzler Folklife Archives and Collections to Smithsonian su… Add Ralph Rinzler Folklife Archives and Collections to Smithsonian subproviders Feb 12, 2024
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stacimc stacimc merged commit 4632941 into main Feb 15, 2024
68 checks passed
@stacimc stacimc deleted the update/smithsonian-subprovider-CFCHFOLKLIFE branch February 15, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants