Edit Site: Reset word-break for TemplateListItem#76105
Closed
ntsekouras wants to merge 2 commits intotrunkfrom
Closed
Edit Site: Reset word-break for TemplateListItem#76105ntsekouras wants to merge 2 commits intotrunkfrom
word-break for TemplateListItem#76105ntsekouras wants to merge 2 commits intotrunkfrom
Conversation
ntsekouras
added
[Type] Regression
|
Size Change: +144 B (0%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
mirka
reviewed
Mar 4, 2026
| flex-direction: column; | ||
| border: $border-width solid $gray-300; | ||
| justify-content: center; | ||
| word-break: normal; |
Member
There was a problem hiding this comment.
This is probably not the "correct" way to fix this particular issue. The text is legitimately overflowing due to the button padding, so eventually the layout will indeed break if we refuse word breaks:
The padding could be reduced if desired, but eventually a word will need to break at some point.
Contributor
Author
There was a problem hiding this comment.
I updated the grid columns number to be 1 on mobile. I think it should be enough. What do you think?
Contributor
Author
There was a problem hiding this comment.
Actually I'm going to close this since it will be handled with the change to overflow-wrap.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
force-pushed
the
followup-76071
branch
from
ae7a7ee to
839f258
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up of: #76071
I manually checked lots of components but Claude helped me with a more thorough audit.
After #76071 added
word-break: break-wordto the base.components-buttonclass, #76084 fixed the first regression inDateTimePicker. This PR addresses another at-risk component found during a broader audit.What was audited
The
word-break: break-wordrule can cause issues on buttons that meet all three conditions:primary,secondary, andtertiaryare protected bywhite-space: nowrapThe audit covered all packages:
components,editor,edit-post,edit-site,block-editor,block-library,dataviews,commands,boot,global-styles-ui,interface,edit-widgets,customize-widgets, andadmin-ui.What was found
Most constrained buttons are safe because they're either icon-only, use a variant with
nowrap, or havewidth: 100%with ample space.TemplateListItem(edit-site, add-new-template) was the one component that needed a fix — default variant buttons with template name text inside a 2–3 column grid.word-break: break-wordcould cause mid-word breaks.I updated the grid columns number to be
1on mobile.The screenshots below are with a really small screen size, but it could possibly occur in different languages in bigger screens.