Merged
Conversation
ntsekouras
added
[Type] Bug
|
Size Change: -6 B (0%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Mar 3, 2026
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
A nice improvement. Love custom class removal and e2e test improvements 🙌
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Sorry for the late reply. I thought this change was safe, but it appears to be causing problems where it shouldn't be wrapping. 
https://wordpress.github.io/gutenberg/?path=/docs/components-datetimepicker--docs At the very least, we might need to check Storybook to see if any visual issues have occurred in any components that depend on the button component. |
alecgeatches
pushed a commit
to Automattic/gutenberg
that referenced
this pull request
Mar 3, 2026
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Contributor
Author
|
Thank you @t-hamano for catching this! I'll investigate more for other possible issues and see how we move forward. |
Member
|
I wonder if |
Contributor
Author
If you want I can make this change. Alternative we could wait to see if there are any reports for this change. In general the DatePicker one was a 'masked' issue, so I think it's fine we made the changes there. |
Member
From what I can gather, it does seem like So I think it would be good to change regardless of any issue reports? |
Contributor
Author
|
I tried replacing with It seems it has to do with the
Any suggestions? |
Member
Maybe pair it with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of: #73707
Alternative of: #73711
From the main issue:
This currently affects only the buttons in Post Summary (editor) and we previously had some ad-hoc css rules per use case.
As suggested by @mirka here:
This PR does that and also removes some of these ad-hoc styles/classnames from the editor components that had them.
Testing Instructions
Notes
I'll open a follow up to handle the DataForms wrapping, since it doesn't use Buttons anymore.