try allowing any content block to be inserted if another content block exists in contentOnly mode#75655
Draft
tellthemachines wants to merge 1 commit intotrunkfrom
Draft
try allowing any content block to be inserted if another content block exists in contentOnly mode#75655tellthemachines wants to merge 1 commit intotrunkfrom
tellthemachines wants to merge 1 commit intotrunkfrom
Conversation
tellthemachines
added
[Type] Enhancement
|
Size Change: -18 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
Contributor
|
I think it works well for a lot of blocks, but it doesn't feel right that you can insert something like a Media & Text block. I realize that one is a content block because it has an image, but it doesn't feel like an 'inline' block, more like a section in and of itself. I'm not really sure how to adequately distinguish these block types and decide what should be allowed by default and what shouldn't. Another situation I'm unsure about is allowing more blocks to be added after the cover in a pattern like this: It would be possible for the pattern designer to restrict this using 'Manage allowed blocks' when designing the pattern, but none of the core bundled patterns have that set 😅 What do you think? |
Contributor
Author
I wonder if we could leverage the "contentRole" support to flag that a block is a content container, and not allow it to be added even if it's also a content block due to having content attributes (Cover and Media-text are only content blocks because you can add media to them i think) |
Contributor
Author
Actually that would invalidate adding Buttons and Galleries which I don't think we want 😅 We need a new not-really-content-container role for this 🙀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Trying something out to address feedback on contentOnly mode here and here.
In contentOnly mode, where a content block exists, it should be possible to insert other content blocks.
This might not work too well for patterns that use container-type content blocks such as Cover and Quote for structural purposes, but let's try it out and see if it improves things!
Testing Instructions