Fix Classic Menu to Navigation Link conversion with entity bindings#72289
Merged
Fix Classic Menu to Navigation Link conversion with entity bindings#72289
Conversation
getdave
requested review from
ajitbohra,
fabiankaegy,
jeryj,
scruffian and
talldan
and removed request for
ajitbohra and
fabiankaegy
getdave
added
[Type] Bug
|
Size Change: +13 B (0%) Total Size: 2.18 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c43a7f2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18465124875
|
getdave
force-pushed
the
fix/classic-menu-entity-bindings
branch
from
c43a7f2 to
148f391
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
force-pushed
the
fix/classic-menu-entity-bindings
branch
from
d3a7ca8 to
a4cb01d
Compare
- Add buildNavigationLinkEntityBinding function to menu-items-to-blocks.js - Update menuItemToBlockAttributes to include entity bindings for non-custom items - Add comprehensive test coverage for entity binding behavior - Ensure classic menu conversions maintain dynamic URL resolution - Follow same pattern as PR #72287 for consistency Fixes classic menu items losing entity relationships during conversion.
getdave
force-pushed
the
fix/classic-menu-entity-bindings
branch
from
a4cb01d to
4992f16
Compare
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
scruffian
approved these changes
Oct 22, 2025
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
Run the navigation tests ✅
Run all navigation-related tests ✅
Manual import of classic navigation ✅
Code review ✅
scruffian
reviewed
Oct 22, 2025
| } ), | ||
| ...( object_id && | ||
| 'custom' !== object && { | ||
| ( inferredKind === 'post-type' || inferredKind === 'taxonomy' ) && { |
Contributor
There was a problem hiding this comment.
Nit: We have similar checks inside buildNavigationLinkEntityBinding. We might want to consider a shared CONST that contains valid kinds.
Contributor
Author
There was a problem hiding this comment.
Yes I think might be necessary although we do have test coverage protection here.
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 22, 2025
…72289) * Fix Classic Menu to Navigation Link conversion with entity bindings - Add buildNavigationLinkEntityBinding function to menu-items-to-blocks.js - Update menuItemToBlockAttributes to include entity bindings for non-custom items - Add comprehensive test coverage for entity binding behavior - Ensure classic menu conversions maintain dynamic URL resolution - Follow same pattern as PR #72287 for consistency Fixes classic menu items losing entity relationships during conversion. * Use canonical building of bindings * Update test expectations * Add edge case coverage for unsupported kinds Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org>
Contributor
|
The automatic backport to the See #72573 for more details. |
t-hamano
added
Backported to WP Core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the Classic Menu to Navigation Link conversion to automatically create entity bindings for dynamic URLs, ensuring converted links maintain their connection to the underlying page entities. This addresses the issue where Classic Menu items converted to Navigation Links were missing the required entity bindings for dynamic URL resolution.
Why
When a Classic Menu is converted to Navigation blocks, the conversion creates Navigation Link blocks but doesn't add the required entity bindings. This means the links don't have dynamic URLs as per #71630, causing them to lose their connection to the underlying page entities.
How
menuItemToBlockAttributesfunction to automatically includemetadata.bindingswhen converting classic menu items that have entity relationships (object_idexists andobjectis not'custom')Testing Instructions
Automated Testing
Manual Testing with WP-CLI
Note: Run the list commands first to get the actual IDs, then use those IDs in the add commands.
Convert in Site Editor:
Verify Entity Bindings:
metadata.bindings.url.source: 'core/entity'metadata.bindingsTest Dynamic URL Updates:
Expected Results
Screenshots
The conversion process now ensures that classic menu items maintain their entity relationships, providing the same dynamic URL capabilities as the Page List conversion from PR #72287.
Related Issues
This addresses the same underlying issue as PR #72287 but for Classic Menu conversions instead of Page List conversions. Both ensure that Navigation Links maintain dynamic URL resolution through entity bindings.
Notes
object_id && 'custom' !== objectalready existed in the code, making this a natural extension