-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Open
Labels
[Block] NavigationAffects the Navigation BlockAffects the Navigation Block[Block] Page ListAffects the Page List BlockAffects the Page List Block
Description
What
Navigation conversion processes need comprehensive coverage to ensure entity bindings are properly created for dynamic URL resolution across all conversion scenarios.
Why
Currently, there are multiple conversion paths that create Navigation Link blocks but don't include the required entity bindings for dynamic URL resolution. This causes converted links to lose their connection to underlying page entities, breaking the dynamic URL functionality introduced in #71630.
Conversion Scenarios That Need Coverage
1. Page List to Navigation Link conversion
- Status: Fixed in PR Fix Page List to Navigation Link conversion with entity bindings #72287
- Issue: Page List blocks converted to Navigation Links were missing entity bindings
- Impact: Links lose dynamic URL resolution when page URLs change
2. Classic Menu to Navigation Link conversion
- Status: Fixed in PR Fix Classic Menu to Navigation Link conversion with entity bindings #72289
- Issue: Classic Menu items converted to Navigation Links were missing entity bindings
- Impact: Links lose dynamic URL resolution when page URLs change
How
- Audit all conversion paths that create Navigation Link blocks
- Ensure entity bindings are included in all conversion scenarios
- Create shared utilities for consistent entity binding creation
- Add comprehensive test coverage for all conversion scenarios
- Document conversion requirements for third-party developers
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
[Block] NavigationAffects the Navigation BlockAffects the Navigation Block[Block] Page ListAffects the Page List BlockAffects the Page List Block
Type
Projects
Status
🦵 Punted to 7.0