Exclude private blocks from the autocompleter#6793
Merged
Conversation
Prevent blocks that do not have supports.inserter set from displaying in the blocks autocompleter.
noisysocks
added
[Type] Bug
noisysocks
commented
May 17, 2018
| ( { category } ) => 'common' !== category | ||
| ) | ||
| ); | ||
| return Promise.resolve( flow( filterBlockTypes, sortBlockTypes )( getBlockTypes() ) ); |
Member
Author
There was a problem hiding this comment.
This is a somewhat temporary fix because @brandonpayton is working on using getInserterItems here which would also fix this bug as well as a lot of similar bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent blocks that do not have
supports.inserterset from displaying in the blocks autocompleter.Fixes the bug that @gziolo noticed in #6766 (comment):
To test:
/to bring up the autocompleter