Rename isPrivate → supports.inserter#6766
Merged
youknowriad merged 1 commit intomasterfrom May 16, 2018
Merged
Conversation
noisysocks
added
the
[Feature] Extensibility
gziolo
approved these changes
May 16, 2018
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
This change itself looks great.
When testing I discovered that Shared block is listed when using the / command. It can be handled separately, your call.
docs/reference/deprecated.md
Outdated
Member
There was a problem hiding this comment.
Should we add here some context? E.g.:
isPrivate: truehas been removed from blocks API.
Member
|
I couldn't attach an image in the review message ... |
gziolo
added
[Feature] Block API
- Removes the inPrivate property in lieu of a supports flag. - Adds documentation for the new flag.
youknowriad
force-pushed
the
update/isPrivate
branch
from
944db2e to
8e81ee5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
inPrivateproperty in lieu of asupportsflag. This came up in #6346 (comment). Also adds documentation so as to fix #4486.How has this been tested?