Zoom out: remove experimental flag #65404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
MaggieCabrera
added
[Feature] Zoom Out
[Type] Feature
|
Size Change: -16 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
@t-hamano landing the experiment is a way to bring the enhancement (UI/UX) over to the release. Can the iframe issue be treated as a bug and solved after? EDIT -- I take it back, that bug looks like a blocker to me. |
|
Another issue with the zoom out mode: #65411 This issue may not be a blocker. |
|
With the release of Gutenberg 19.3 RC fast approaching (https://wordpress.slack.com/archives/C02QB2JS7/p1726624220894339), I think for now we need to decide whether to tolerate the bug and merge this PR or not. cc @noisysocks |
|
If you have capacity to fix zoomed out mode bugs during the beta period (next 5 weeks) then I say go for it! |
|
I found one other problem. Altogether, I found at least three problems:
It shouldn’t be hard to fix these issues during the beta phase and I’m happy to help, but I’m personally leaning towards stabilizing the zoom out mode after the WP 6.7 beta phase begins and doing some more testing on the Gutenberg plugin. What do you think? |
We are definitely going to be working on those and other bugs that the mode has so it's in a good place for 6.7, but to have a chance for the feature to make it, it needs to go in this GB release. |
draganescu
approved these changes
Sep 18, 2024
fabiankaegy
added
the
Needs Dev Note
2 tasks
Closed
2 tasks
This was referenced Sep 26, 2024
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the experimental flag that was hiding the zoom out mode toggle on the top toolbar
Why?
To bring more eyes to the mode ahead of 6.7
How?
Just removes the experiment
Testing Instructions
You should see the zoom out mode icon on the toolbar on a fresh install with this PR enabled
Testing Instructions for Keyboard
Screenshots or screencast