attempt to fix php unit tests (variations api change) #58090
Conversation
ellatrix
added
the
[Type] Automated Testing
|
Flaky tests detected in 2c99c0d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7616204409
|
There was a problem hiding this comment.
This looks like the same approach @kt-12 was suggesting in #58072. If it unblocks tests, I think this approach is fine for now.
Long term, I think we should rethink the way this block is handling modifying variations when post or taxonomy types are modified, since it doesn't really make sense for variations on the server to be modified after the property is accessed, which really only happens once per request in order to provide data to the editor.
|
Oh, somehow I missed that PR |
ellatrix
changed the title
|
@joemcgill @ellatrix I have cross-checked. This does fix the issue, we can merge anyone of the PRs as both are the same. On a side note - https://github.com/WordPress/gutenberg/pull/56100/files has changed the names of a couple of public functions. Doesn't Gutenberg depreciate the old function while adding a new one? |
|
@kt-12 let's keep the discussion in this PR focused on fixing the unit tests for now. FWIW, I don't see any changed names in the PR you referenced but if there are concerns, we should discuss them in a separate issue, or in the original PR instead. |
My bad - wanted to reference https://github.com/WordPress/gutenberg/pull/56100/files. Yes, let's discuss this separately. |
|
@kt-12 Sorry, I enabled merge for this PR because the other had test failures at the time |
|
@ellatrix That's fine, in fact, you saved my time. I thought there was still some reference problem with the variable and was behind it. |
…n't clash with the one backported to core (#58429) * Navigation: Move the renderer class to the main navigation file (#57979) * Navigation: Move the renderer class to the main navigation file to take advantage of the automatic backporting * Update the build script to also copy over class files * prefix with gutenberg * Add a Gutenberg suffix to class files when they are built * add gutenberg prefix to functions * move the built block files to their own dir * Putting back the render class into the same file as the navigation block * Update the rendered post rebase * Fix php unit tests --------- Co-authored-by: Riad Benguella <benguella@gmail.com> * Use the right renderer class * Fix php unit tests (after variations api change) (#58090) --------- Co-authored-by: Riad Benguella <benguella@gmail.com> Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com>
What?
I don't know anything about this, maybe it works, maybe more adjustments are needed.It works, PHP unit tests are passing.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast